-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update server.xml for 6.5.x (since like 5.4.0 actually) #131
base: master
Are you sure you want to change the base?
Conversation
9b1d61e
to
53f74c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@TJM I think we should make the custom |
Sorry, I think this branch got mixed up with my "all fixes to make it work" ... it was supposed to be just the server.xml fixes. :) @jainishshah17 I wondered if the custom server.xml was actually needed. I think it mostly has to do with changing the application port to match what was assigned through docker? right? |
dc-os/Docker/HA/Dockerfile
Outdated
ADD files/access/etc/keys/root.crt /var/opt/jfrog/artifactory/access/etc/keys/root.crt | ||
ADD files/security/communication.key /var/opt/jfrog/artifactory/communication.key | ||
RUN mkdir -p /var/opt/jfrog/artifactory/access/etc/keys/ /var/opt/jfrog/artifactory/etc/security/ | ||
COPY --chown=artifactory:artifactory files/access/etc/keys/private.key /var/opt/jfrog/artifactory/access/etc/keys/private.key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section concerns me. I don't really feel like pre-populating the same keys in everyone's HA artifactory is a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TJM We don't need this anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will remove them.
@TJM Yes, |
@jainishshah17 The server.xml also has some other stuff:
vs
Are these still needed (desired)? |
47be750
to
ff58105
Compare
Maybe it would be better to "generate" the key in the entrypoint script and put it in shared storage? |
What is the status of this? Do I need to do anything else (besides bumping the versions?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Here are some updates, per https://www.jfrog.com/confluence/display/RTF/Upgrading+Artifactory
startStopThreads="2"
(since 5.4.0)sendReasonPhrase="true"
to all connectors (since 5.6.1)relaxedPathChars='[]' relaxedQueryChars='[]'
(since 6.3.0)I am not sure why AJP is commented out, but I left it that way, and just added the new options, in case someone needs to enable it.
Also, I am not sure why the shutdown port is disabled, since the "stop" process tries to use it.
Interestingly, the "PRO" version questions whether this is needed. Is it still needed?
~tommy